971195 - [B2G][Calendar] Events longer than one hour do not show correctly in Month and Day view

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
Online and offline calendars show events that are longer than one hour as occupying a single hour's worth of space in Month and Day view. User is able to select times that the event occupies in Day view, bringing up new event creation page.

Repro Steps:
1) Updated Buri to BuildID: 20140211040200
2) Open Calendar app
3) Tap + icon in top right corner
4) Have event span several hours in a single day, then save event
5) View event in agenda section of month view
6) View event in day view

Actual:
Multi-hour events display incorrectly in Month and Day view.

Expected:
Multi-hour events display correctly.

Environmental Variables:
Device: Buri v1.4 Mozilla RIL
BuildID: 20140211040200
Gaia: 9fc36dde3a4a3c5ca200275b68ffb56b4173bec3
Gecko: d812f80a0f1d
Version: 30.0a1
Firmware Version: V1.2-device.cfg

Notes:
Repro frequency: 3/3, 100%
See attached: screenshot

Comment 1

[Natalya Kot [:nkot]]

This issue also reproduces on today's 1.3.
We are working on getting regression range for both 1.3 and 1.4

Comment 2

[Tony Nguyen]

Regression window for 1.3:
~First broken~
BuildID: 20140211004035
Gaia: 00cd1ae74dfe773a41b55275b0b468a62f35076d
Gecko: 873e98e750bf
Version: 28.0

~Last working~
BuildID: 20140210004002
Gaia: 5c8416fb1ea4a27f172ee6386ab3c19135448506
Gecko: 9c9382f433c0
Version: 28.0

Regression window for 1.4:
~First broken~
BuildID: 20140211040200
Gaia: 9fc36dde3a4a3c5ca200275b68ffb56b4173bec3
Gecko: d812f80a0f1d
Version: 30.0a1

~Last working~
BuildID: 20140210040202
Gaia: c273bd6525f7f295539592ce74d5e6b225d53be1
Gecko: ecf20a2484b6
Version: 30.0a1

Comment 3

[Jason Smith [:jsmith]]

This needs to be bisected using tinderbox builds.

Comment 4

[Miller Medeiros [:millermedeiros]]

there are 2 ways to fix this bug:

 1. set `.day-events .event` "z-index:1" (so event container goes over the next hour "lines" and "background")
 2. remote "backgorund-color" from `.day-events > .hour`

option #1 makes more sense to me. I think this should block b2g:1.3+

Comment 5

[Miller Medeiros [:millermedeiros]]

there are 2 ways to fix this bug:

 1. set `.day-events .event` "z-index:1" (so event container goes over the next hour "lines" and "background")
 2. remove "background-color" from `.day-events > .hour`

option #1 makes more sense to me. I think this should block b2g:1.3+

Comment 6

[Miller Medeiros [:millermedeiros]]

Attachment: quick fix options

option #1 to the left, #2 on the right. please let us know which option suits better.

Comment 7

[Jason Smith [:jsmith]]

I think we really need to know what regressed this before we propose a fix. Whatever busted this should really be backed out - there's something fundamentally broken here.

Comment 8

[Jason Smith [:jsmith]]

https://github.com/mozilla-b2g/gaia/compare/5c8416fb1ea4a27f172ee6386ab3c19135448506...00cd1ae74dfe773a41b55275b0b468a62f35076d

Comment 9

[Jason Smith [:jsmith]]

Found the regressing patch:

https://github.com/mozilla-b2g/gaia/pull/16127/files

Comment 10

[Dylan Oliver [:doliver]]

Thanks for the investigation Jason -- I pinged Mason about a backout on bug 968478.

Comment 11

[Jason Smith [:jsmith]]

Fixed via backout - https://bugzilla.mozilla.org/show_bug.cgi?id=968478#c9.

Comment 12

[Natalya Kot [:nkot]]

Fixed for 1.3, still happening on 1.4, should it be fixed in 1.4 too?

buri 1.4 maaster
BuildID: 20140212040203
Gaia: 4c6b5142d3b716f1c4ea502eeb92d3119f2b01c6
Gecko: 802d87c77e76
Version: 30.0a1

buri 1.3
BuildID: 20140212004003
Gaia: ce17d5eae7b1893ae4397c814b10ae598fcbdb58
Gecko: ab07e61c2eb0
Version: 28.0

Comment 13

[Jason Smith [:jsmith]]

(In reply to Natalya Kot [:nkot] from comment #12)
> Fixed for 1.3, still happening on 1.4, should it be fixed in 1.4 too?
> 
> buri 1.4 maaster
> BuildID: 20140212040203
> Gaia: 4c6b5142d3b716f1c4ea502eeb92d3119f2b01c6
> Gecko: 802d87c77e76
> Version: 30.0a1
> 
> buri 1.3
> BuildID: 20140212004003
> Gaia: ce17d5eae7b1893ae4397c814b10ae598fcbdb58
> Gecko: ab07e61c2eb0
> Version: 28.0

Open a followup for this then.

Comment 14

[Natalya Kot [:nkot]]

opened followup bug 971904